Conversation
This was referenced Dec 22, 2021
gyst
approved these changes
Dec 22, 2021
Contributor
gyst
left a comment
gyst
left a comment
There was a problem hiding this comment.
I discussed this change with Cornelis and he told me the "pre-loading" of items just before they will become visible, is not handled in javascript but in markup.
From my perspective this is a valid and minimal solution to #939. I propose to merge this and not do the more invasive refactorings of the other PRs, at least not now.
Fix autload-visible trigger to only load the injection if the element is in the viewport. As before, this check is done after 100ms. This prevents loading items when we quickly scoll across them, like with href-section-jumps.
thet
force-pushed
the
inject-autoload-visible-checkviewport
branch
from
2602c5f to
756182b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix #939
Alternative approach: #941